[win] Add Hot Restart define constant in a target instead of an evaluation property #17470
Conversation
…ation property This is needed in order to read the correct value of the "IsHotRestartBuild" property set by the VS extension. Doing it in a PropertyGroup at evaluation was not getting the correct value since it was not being set as an MSBuild global property
|
/sudo backport release/7.0.1xx-xcode14.2 |
|
/sudo backport release/6.0.4xx-xcode14.2 |
|
Backport Job to branch release/7.0.1xx-xcode14.2 Created! The magic is happening here |
|
Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7297408 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7297412 for more details. |
|
/sudo backport xcode14.2 |
|
Backport Job to branch xcode14.2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7297447 for more details. |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 3 tests failed, 222 tests passed. Failures❌ xammac tests [attempt 2]
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
… of an evaluation property (#17473) This is needed in order to read the correct value of the "IsHotRestartBuild" property set by the VS extension. Doing it in a PropertyGroup at evaluation was not getting the correct value since it was not being set as an MSBuild global property This PR is related to this other one in the XVS extension: xamarin/XamarinVS#13612 Backport of #17470 Co-authored-by: Mauro Agnoletti <[email protected]>
…a target instead of an evaluation property. (#17472) This is needed in order to read the correct value of the "IsHotRestartBuild" property set by the VS extension. Doing it in a PropertyGroup at evaluation was not getting the correct value since it was not being set as an MSBuild global property This PR is related to this other one in the XVS extension: xamarin/XamarinVS#13612 Backport of #17470 Co-authored-by: Mauro Agnoletti <[email protected]>
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630). |
rolfbjarne
changed the title
…a target instead of an evaluation property. (#17471) This is needed in order to read the correct value of the "IsHotRestartBuild" property set by the VS extension. Doing it in a PropertyGroup at evaluation was not getting the correct value since it was not being set as an MSBuild global property This PR is related to this other one in the XVS extension: xamarin/XamarinVS#13612 Backport of #17470 Co-authored-by: Mauro Agnoletti <[email protected]>
…ation property
This is needed in order to read the correct value of the "IsHotRestartBuild" property set by the VS extension. Doing it in a PropertyGroup at evaluation was not getting the correct value since it was not being set as an MSBuild global property
This PR is related to this other one in the XVS extension: https://github.com/xamarin/XamarinVS/pull/13612